Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minimize permissions to CI workflows #103

Merged
merged 1 commit into from
Mar 21, 2023
Merged

Conversation

sywhang
Copy link
Contributor

@sywhang sywhang commented Mar 20, 2023

Set only read permission on CI workflows since they don't need write access.

Set only read permission on CI workflows since they don't need write access.
@codecov
Copy link

codecov bot commented Mar 20, 2023

Codecov Report

Merging #103 (cc6ea78) into master (751da59) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #103   +/-   ##
=======================================
  Coverage   96.52%   96.52%           
=======================================
  Files           5        5           
  Lines         230      230           
=======================================
  Hits          222      222           
  Misses          5        5           
  Partials        3        3           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@r-hang r-hang merged commit 4a14d38 into uber-go:master Mar 21, 2023
@mway mway mentioned this pull request Oct 24, 2023
mway added a commit that referenced this pull request Oct 24, 2023
### Fixed
- Built-in ignores now match function names more accurately.
  They will no longer ignore stacks because of file names
  that look similar to function names. (#112)
### Added
- Add an `IgnoreAnyFunction` option to ignore stack traces
  that have the provided function anywhere in the stack. (#113)
- Ignore `testing.runFuzzing` and `testing.runFuzzTests` alongside
  other already-ignored test functions (`testing.RunTests`, etc). (#105)

### Changed
- Miscellaneous CI-related fixes. (#103, #108, #114)

---------

Co-authored-by: Abhinav Gupta <mail@abhinavg.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants